Release/1.1.1 #13
Merged
Release/1.1.1 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….AdditionalTextConstantGenerator
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a release PR for version 1.1.1 that modernizes the codebase by adopting external utility libraries and improves compatibility with older .NET versions. The update removes internal implementations in favor of standardized libraries and fixes nullable reference type support.
- Adopts Datacute.IncrementalGeneratorExtensions and Datacute.AdditionalTextConstantGenerator for better code reuse
- Improves nullable reference type compatibility for older .NET versions
- Updates versioning system to support multiple build profiles
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.props | Updates version to 1.1.1 and adds dynamic versioning system |
| EmbeddedResourcePropertyGenerator/*.cs | Refactors to use external libraries and improves nullable support |
| Templates.cs | Updates template constants and removes indentation parameters |
| CodeGenerator.cs | Converts to inherit from SourceTextGeneratorBase with cleaner structure |
| Tests | Updates test infrastructure and snapshot verifications |
| global.json | Adds .NET SDK version specification |
| Project files | Removes attributes project and updates package references |
| /// </remarks> | ||
| [System.Diagnostics.Conditional("DATACUTE_EMBEDDEDRESOURCEPROPERTIES_USAGES")] | ||
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)] | ||
| internal sealed class EmbeddedResourcePropertiesAttribute : Attribute |
There was a problem hiding this comment.
The attribute class is marked as 'internal' which may prevent it from being used by consuming projects. Consider making it 'public' to ensure proper accessibility for source generator scenarios.
Suggested change
| internal sealed class EmbeddedResourcePropertiesAttribute : Attribute | |
| public sealed class EmbeddedResourcePropertiesAttribute : Attribute |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.